Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 'mode' in table scheme #1219

Merged
merged 2 commits into from
Nov 13, 2015
Merged

Missing 'mode' in table scheme #1219

merged 2 commits into from
Nov 13, 2015

Conversation

silentsokolov
Copy link
Contributor

If the table has been created through the web UI and set mode for field NULLABLE, the mode in API will not be returned

Request:

GET https://www.googleapis.com/bigquery/v2/projects/test-project/datasets/test-dataset/tables/test-table?fields=schema&key={API_KEY}

Response:

{
    "schema": {
        "fields": [{
            "name": "redate",
            "type": "TIMESTAMP"
        }, {
            "name": "bar",
            "type": "RECORD",
            "fields": [{
                "name": "foo",
                "type": "STRING"
            }]
        }]
    }
}

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 13, 2015
@silentsokolov
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 13, 2015
@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Nov 13, 2015
@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2015

Thanks for the patch! Can you please add a testcase exercising the missing mode to [gcloud.bigquery.test_table.Test_parse_schema_resource](https://github.com/GoogleCloudPlatform/gcloud-python/blob/b71ac5138a98c81dd14f8ee630fd67758ae15859/gcloud/bigquery/test_table.py#L1243-L1275}?

@silentsokolov
Copy link
Contributor Author

Done

@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2015

Thanks very much!

tseaver added a commit that referenced this pull request Nov 13, 2015
@tseaver
Merge pull request #1219 from silentsokolov/missing-mode-in-table
f88d59e 
Missing 'mode' in table scheme
@tseaver tseaver merged commit f88d59e into googleapis:master Nov 13, 2015
@dhermes
Copy link
Contributor

dhermes commented Nov 14, 2015

w00t!

Thanks a lot @silentsokolov

@silentsokolov silentsokolov deleted the missing-mode-in-table branch December 24, 2015 06:43
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silentsokolov @googlebot @tseaver @dhermes